nebula-project/NebulaBrowser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Replace UNREFERENCED_PARAMETER with NEBULA_UNUSED

Browse Source 
Introduce NEBULA_UNUSED macro in platform types and replace usages of UNREFERENCED_PARAMETER across multiple source files to standardize unused-parameter handling. Update various platform stubs (Linux window/host), CEF handlers, and Windows startup code to use NEBULA_UNUSED. Also adjust NebulaController::OnWindowCloseRequested to stop force-destroying the top-level window and rely on MaybeFinishShutdown once browsers report OnBeforeClose.
This commit is contained in:
Andrew Zambazos
2026-05-19 15:08:39 +12:00
parent 29908646ea
commit bbba5b2927
9 changed files with 54 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cef/browser_client.cpp
+22 -22
View File
@@ -82,8 +82,8 @@ bool NebulaBrowserClient::OnProcessMessageReceived(CefRefPtr<CefBrowser> browser
CefProcessId source_process,
CefRefPtr<CefProcessMessage> message) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(browser);
UNREFERENCED_PARAMETER(source_process);
NEBULA_UNUSED(browser);
NEBULA_UNUSED(source_process);
if (!message || message->GetName().ToString() != kChromeCommandMessage) {
return false;
@@ -162,7 +162,7 @@ bool NebulaBrowserClient::OnPreKeyEvent(CefRefPtr<CefBrowser> browser,
CefEventHandle os_event,
bool* is_keyboard_shortcut) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(os_event);
NEBULA_UNUSED(os_event);
if (role_ == BrowserRole::Content &&
event.type == KEYEVENT_RAWKEYDOWN &&
@@ -194,17 +194,17 @@ bool NebulaBrowserClient::OnBeforePopup(CefRefPtr<CefBrowser> browser,
CefRefPtr<CefDictionaryValue>& extra_info,
bool* no_javascript_access) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(frame);
UNREFERENCED_PARAMETER(popup_id);
UNREFERENCED_PARAMETER(target_frame_name);
UNREFERENCED_PARAMETER(target_disposition);
UNREFERENCED_PARAMETER(user_gesture);
UNREFERENCED_PARAMETER(popupFeatures);
UNREFERENCED_PARAMETER(windowInfo);
UNREFERENCED_PARAMETER(client);
UNREFERENCED_PARAMETER(settings);
UNREFERENCED_PARAMETER(extra_info);
UNREFERENCED_PARAMETER(no_javascript_access);
NEBULA_UNUSED(frame);
NEBULA_UNUSED(popup_id);
NEBULA_UNUSED(target_frame_name);
NEBULA_UNUSED(target_disposition);
NEBULA_UNUSED(user_gesture);
NEBULA_UNUSED(popupFeatures);
NEBULA_UNUSED(windowInfo);
NEBULA_UNUSED(client);
NEBULA_UNUSED(settings);
NEBULA_UNUSED(extra_info);
NEBULA_UNUSED(no_javascript_access);
if (role_ == BrowserRole::Content && delegate_) {
delegate_->OnPopupRequested(browser, target_url.ToString());
@@ -233,8 +233,8 @@ void NebulaBrowserClient::OnLoadingStateChange(CefRefPtr<CefBrowser> browser,
bool canGoBack,
bool canGoForward) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(canGoBack);
UNREFERENCED_PARAMETER(canGoForward);
NEBULA_UNUSED(canGoBack);
NEBULA_UNUSED(canGoForward);
if (role_ == BrowserRole::Content && delegate_) {
delegate_->OnContentLoadingStateChanged(browser, isLoading);
@@ -245,7 +245,7 @@ void NebulaBrowserClient::OnLoadStart(CefRefPtr<CefBrowser> browser,
CefRefPtr<CefFrame> frame,
TransitionType transition_type) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(transition_type);
NEBULA_UNUSED(transition_type);
if (role_ == BrowserRole::Content && delegate_ && frame && frame->IsMain()) {
delegate_->OnContentLoadProgressChanged(browser, 0.12);
@@ -275,9 +275,9 @@ bool NebulaBrowserClient::OnBeforeBrowse(CefRefPtr<CefBrowser> browser,
bool user_gesture,
bool is_redirect) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(browser);
UNREFERENCED_PARAMETER(user_gesture);
UNREFERENCED_PARAMETER(is_redirect);
NEBULA_UNUSED(browser);
NEBULA_UNUSED(user_gesture);
NEBULA_UNUSED(is_redirect);
if (role_ == BrowserRole::Content && frame && frame->IsMain() && request) {
const std::string url = request->GetURL().ToString();
@@ -309,8 +309,8 @@ bool NebulaBrowserClient::OnShowPermissionPrompt(
uint32_t requested_permissions,
CefRefPtr<CefPermissionPromptCallback> callback) {
CEF_REQUIRE_UI_THREAD();
UNREFERENCED_PARAMETER(prompt_id);
UNREFERENCED_PARAMETER(requesting_origin);
NEBULA_UNUSED(prompt_id);
NEBULA_UNUSED(requesting_origin);
if (role_ == BrowserRole::Content &&
(requested_permissions & CEF_PERMISSION_TYPE_GEOLOCATION) != 0 &&
src/cef/nebula_app.cpp
+5 -5
View File
@@ -16,8 +16,8 @@ public:
const CefV8ValueList& arguments,
CefRefPtr<CefV8Value>& retval,
CefString& exception) override {
UNREFERENCED_PARAMETER(object);
UNREFERENCED_PARAMETER(retval);
NEBULA_UNUSED(object);
NEBULA_UNUSED(retval);
if (name != "postMessage" && name != "sendToHost" && name != "send") {
return false;
@@ -55,7 +55,7 @@ private:
void NebulaApp::OnBeforeCommandLineProcessing(const CefString& process_type,
CefRefPtr<CefCommandLine> command_line) {
UNREFERENCED_PARAMETER(process_type);
NEBULA_UNUSED(process_type);
// The bundled UI is loaded from file:// and uses ES modules.
command_line->AppendSwitch("allow-file-access-from-files");
@@ -92,8 +92,8 @@ void NebulaApp::OnContextCreated(CefRefPtr<CefBrowser> browser,
CefRefPtr<CefFrame> frame,
CefRefPtr<CefV8Context> context) {
CEF_REQUIRE_RENDERER_THREAD();
UNREFERENCED_PARAMETER(browser);
UNREFERENCED_PARAMETER(frame);
NEBULA_UNUSED(browser);
NEBULA_UNUSED(frame);
CefRefPtr<CefV8Value> global = context->GetGlobal();
CefRefPtr<NativeBridgeHandler> handler = new NativeBridgeHandler();